Our server pr0vider carried out maintenance on 15 January 2020 but it corrupted some files in the process. If you notice anything out of the ordinary (partial files, pages not loading, that kind of shit) then let us know at:

#28 sacmds module install compile warnings

Closed
opened 4 months ago by westor · 1 comments
westor commented 4 months ago

Hello,

I saw some warning when i tried to install the module (latest unrealircd .git) , i am not sure if this is important or not, but just in any case i report it..

sacmds.c: In function ‘cmd_sanick’:
sacmds.c:218:36: warning: format not a string literal and no format arguments [-Wformat-security]
  218 |   sendto_snomask_global(SNO_SACMD, snotice); // Send notice to all 0pers
      |                                    ^~~~~~~
sacmds.c: In function ‘cmd_saumode’:
sacmds.c:383:37: warning: format not a string literal and no format arguments [-Wformat-security]
  383 |    sendto_snomask_global(SNO_SACMD, snotice); // Send notice to all 0pers
  • Thanks!
Hello, I saw some warning when i tried to install the module (latest unrealircd .git) , i am not sure if this is important or not, but just in any case i report it.. ``` sacmds.c: In function ‘cmd_sanick’: sacmds.c:218:36: warning: format not a string literal and no format arguments [-Wformat-security] 218 | sendto_snomask_global(SNO_SACMD, snotice); // Send notice to all 0pers | ^~~~~~~ sacmds.c: In function ‘cmd_saumode’: sacmds.c:383:37: warning: format not a string literal and no format arguments [-Wformat-security] 383 | sendto_snomask_global(SNO_SACMD, snotice); // Send notice to all 0pers ``` - Thanks!
Wazakindjes commented 1 month ago
Owner

Nah that's cool, Unreal's sendto_* functions use a form of sprintf to convert a string like hello %s to hello westor. I was doing that part myself to keep the code a little cleaner, but if some compilers throw a warning then it should be done the "proper" way after all. So, I just updated the module, thanks fam. ;]

Nah that's cool, Unreal's `sendto_*` functions use a form of `sprintf` to convert a string like `hello %s` to `hello westor`. I was doing that part myself to keep the code a little cleaner, but if some compilers throw a warning then it should be done the "proper" way after all. So, I just updated the module, thanks fam. ;]
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.